Skip to content

More Emma-related updates #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2025
Merged

More Emma-related updates #804

merged 5 commits into from
Oct 19, 2025

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 19, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added support for Emma Pro wired devices.
    • Renamed existing wireless Emma device to Emma Pro for consistency.
    • Device sample data updated to reflect the new model name.

  • Chores

    • Version bumped to 1.8.2a0 (pre-release).
    • Changelog updated with an "Ongoing" subsection noting the Emma Pro changes.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025 •
edited
Loading

Walkthrough

This PR renames the wireless "Emma" model to "Emma Pro", adds a new "Emma Pro wired" model entry, bumps the package version to 1.8.2a0, updates the changelog, and adjusts test data to use the new model name.

Changes

Cohort / File(s) Summary
Hardware Model Definitions
plugwise/constants.py		 Added "170.1": "Emma Pro wired" to HW_MODELS; changed "170-01": "Emma" → "170-01": "Emma Pro"; added a commented placeholder for an "Emma Essential" entry.
Version and Changelog
pyproject.toml, CHANGELOG.md		 Bumped project version from 1.8.1 → 1.8.2a0; added an "Ongoing" changelog entry documenting Emma Pro wired support and the wireless rename.
Test Data Alignment
tests/data/adam/adam_anna_new_2.json		 Updated device model name from "Emma" to "Emma Pro" for a test fixture.

Sequence Diagram(s)

(omitted — changes are data/constants/versioning only, no control-flow modifications)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • CoMPaTech

Poem

🐰 I hopped in to tweak a name,
Emma Pro arrives — wired and tame.
A tiny version leap, tests in tow,
Constants aligned — off we go! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The pull request title "More Emma-related updates" is directly related to the primary changes in the changeset. The modifications center on Emma device support: adding "Emma Pro wired" as a new hardware model, renaming the existing "Emma" to "Emma Pro", updating version metadata to "1.8.2a0", and updating corresponding test data. The title appropriately identifies Emma as the subject of the changes, and while the word "updates" is somewhat generic, it is sufficiently specific when paired with "Emma-related" to convey meaningful information about the changeset. A developer reviewing the pull request history would understand this is about Emma device modifications.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch emma-adam-wired

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bouwew bouwew marked this pull request as ready for review October 19, 2025 08:43
@bouwew bouwew requested a review from a team as a code owner October 19, 2025 08:43
@bouwew bouwew requested a review from CoMPaTech October 19, 2025 08:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (569686e) to head (d9d77c4).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #804   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3414      3414           
=========================================
  Hits          3414      3414

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwew bouwew changed the title More Emma-related More Emma-related updates Oct 19, 2025
@bouwew bouwew merged commit e78638e into main Oct 19, 2025
18 checks passed
@bouwew bouwew deleted the emma-adam-wired branch October 19, 2025 09:00
@coderabbitai coderabbitai bot mentioned this pull request Oct 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bouwew @CoMPaTech